Edinburgh is always a treasure trove but it can be hard to find the gold among the glitter. Holly Williams offers up her top picks to delight, surprise, move or provoke